[cryptotest] Remove rsa_pss_4096_sha512_mgf1_32 test #28790
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `rsa_padding_pss_verify`, `salt_bytelen = digest_bytelen`. Hence, the test where we use a digest bytelen of 64 bytes (for SHA512) but only use a salt bytelen of 32 bytes cannot work. According to RFC 8017, 9.1.4: "Typical salt lengths in octets are hLen (the length of the output of the hash function Hash) and 0." Closes lowRISC#28656. Signed-off-by: Pascal Nasahl <[email protected]>
andrea-caforio
approved these changes
Nov 20, 2025
Contributor
andrea-caforio
left a comment
andrea-caforio
left a comment
There was a problem hiding this comment.
Nice. Thanks for taking care of this @nasahlpa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
rsa_padding_pss_verify,salt_bytelen = digest_bytelen. Hence, the test where we use a digest bytelen of 64 bytes (for SHA512) but only use a salt bytelen of 32 bytes cannot work.According to RFC 8017, 9.1.4: "Typical salt lengths in octets are hLen (the length of the output of the hash function Hash) and 0."
Closes #28656.